Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eager load multiple nested relations using @with #2525

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Eager load multiple nested relations using @with #2525

wants to merge 6 commits into from

Conversation

spawnia
Copy link
Collaborator

@spawnia spawnia commented Mar 14, 2024 •
edited
Loading

Resolves #1132, probably also #1873

  • Added or updated tests
  • Documented user facing changes
  • Updated CHANGELOG.md

Changes

Breaking changes

@spawnia spawnia added the bug An error within Lighthouse label Mar 28, 2024
@spawnia spawnia mentioned this pull request Jun 5, 2024
Open
@robsontenorio
Copy link
Contributor

In this exactly old version 5.70.3, the nested relationship eager loading works .
But not on latest state version 6.x.

type Bar { 
      city: City  @method(name: "handleCity") @with(relation: "city.state")
}

@robsontenorio
Copy link
Contributor

robsontenorio commented Jun 13, 2024 •
edited
Loading

By the way , I have tested this PR and works fine, solve the problem. If you need some help to merge it let me know.

@spawnia
Copy link
Collaborator Author

spawnia commented Jun 14, 2024

By the way , I have tested this PR and works fine, solve the problem. If you need some help to merge it let me know.

The changes I made fix eager loading of multiple @with, but break other scenarios - see https://github.com/nuwave/lighthouse/actions/runs/9380728096/job/25828392738. Thus, it can not be merged as is, the final solution will have to look different.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug An error within Lighthouse
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Eager-load multiple relationships through @with
2 participants
@spawnia @robsontenorio